➜
This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to
log in and link your GitHub username to your profile.
For more information,
see this post about the migration.
Created on 2019-02-01 14:02 by pablogsal, last changed 2019-02-01 15:14 by vstinner. This issue is now closed.
| Messages (5) | |||
|---|---|---|---|
| msg334676 - (view) | Author: Pablo Galindo Salgado (pablogsal) *  |
Date: 2019-02-01 14:02 | |
The refleak buildbots have detected that test_type_comments is leaking references. Example failure: https://buildbot.python.org/all/#/builders/1/builds/490/steps/4/logs/stdio test_type_comments leaked [37, 37, 37] references, sum=111 test_type_comments leaked [11, 12, 11] memory blocks, sum=34 1 test failed again: test_type_comments Bisecting shows that PR11645 is the one that introduced the refleaks: https://github.com/python/cpython/pull/11645/files# After some hours of debugging, I have identified the (possible) cause of the majority of the refleaks. The type_comments created in ast.c with new_type_comment() never reaches 0 reference counts. This **seems** to be because the cleanup for the stmt_ty elements where the type_comments are included never call DECREF on these elements when destroyed unless I am missing something fundamental. |
|||
| msg334679 - (view) | Author: Karthikeyan Singaravelan (xtreak) * |
Date: 2019-02-01 14:07 | |
This looks like the same as https://bugs.python.org/issue35879 |
|||
| msg334680 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-02-01 14:08 | |
> This looks like the same as https://bugs.python.org/issue35879 Yeah, as usual Pablo is way too slow: he posted the same bug 1h30 after me. |
|||
| msg334681 - (view) | Author: Pablo Galindo Salgado (pablogsal) * |
Date: 2019-02-01 14:11 | |
> Yeah, as usual, Pablo is way too slow: he posted the same bug 1h30 after me. :( |
|||
| msg334686 - (view) | Author: STINNER Victor (vstinner) * |
Date: 2019-02-01 15:14 | |
> :( I'm kidding :-) Sorry for not reviewing emails from buildbot-status. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2019-02-01 15:14:41 | vstinner | set | messages: + msg334686 |
| 2019-02-01 14:11:08 | pablogsal | set | messages: + msg334681 |
| 2019-02-01 14:09:03 | vstinner | set | status: open -> closed superseder: test_type_comments leaks references resolution: duplicate stage: resolved |
| 2019-02-01 14:08:33 | vstinner | set | messages: + msg334680 |
| 2019-02-01 14:07:19 | xtreak | set | nosy:
+ xtreak, vstinner messages: + msg334679 |
| 2019-02-01 14:02:45 | pablogsal | create | |