Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the start and end locations of Tuple #4340

Merged
merged 2 commits into from Dec 18, 2022
Merged

Fix the start and end locations of Tuple #4340

merged 2 commits into from Dec 18, 2022

Conversation

harupy
Copy link
Contributor

@harupy harupy commented Dec 18, 2022 •
edited

This PR fixes the start and end locations of Tuple.

Current:

(1, 2, 3)
 ^-----^
 doesn't include ()

Fixed:

(1, 2, 3)
^-------^
includes ()

@harupy harupy changed the title Fix locations of parethesized expressions Fix locations of parenthesized expressions Dec 18, 2022
@harupy harupy changed the title Fix locations of parenthesized expressions Fix the start and end locations of Tuple Dec 18, 2022
@DimitrisJim DimitrisJim merged commit c01f014 into RustPython:main Dec 18, 2022
13 checks passed
@DimitrisJim
Copy link
Member

DimitrisJim commented Dec 18, 2022

thanks @harupy!

@harupy
Copy link
Contributor Author

harupy commented Dec 18, 2022

@DimitrisJim Thanks for the merge!

@harupy harupy deleted the fix-locations-of-parethesized-expressions branch Dec 18, 2022
@harupy harupy mentioned this pull request Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DimitrisJim DimitrisJim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harupy @DimitrisJim