add boltons #8892
add boltons #8892
Conversation
|
@sobolevn |
This comment has been minimized.
This comment has been minimized.
Thanks, this is good start.
I think we would need to:
- Fix flake8. Right now it says:
./stubs/boltons/boltons/timeutils.pyi:46:20: F821 undefined name 'DSTEND_1987_2006'
./stubs/boltons/boltons/funcutils.pyi:45:5: F811 redefinition of unused 'get_sig_str' from line 43
./stubs/boltons/boltons/funcutils.pyi:46:5: F811 redefinition of unused 'get_invocation_str' from line 44
./stubs/boltons/boltons/funcutils.pyi:54:5: F811 redefinition of unused 'add_arg' from line 53
./stubs/boltons/boltons/urlutils.pyi:92:1: F811 redefinition of unused 'OrderedMultiDict' from line 5
./stubs/boltons/boltons/deprutils.pyi:5:26: F821 undefined name 'ModuleType'
./stubs/boltons/boltons/ioutils.pyi:5:13: F821 undefined name 'unicode'
./stubs/boltons/boltons/tbutils.pyi:3:8: F821 undefined name 'unicode'
./stubs/boltons/boltons/fileutils.pyi:50:12: F821 undefined name 'copy_tree'
./stubs/boltons/boltons/iterutils.pyi:66:5: F811 redefinition of unused '__next__' from line 65
./stubs/boltons/boltons/iterutils.pyi:72:5: F811 redefinition of unused 'reseed' from line 71
You need to define / import all missing names.
- Mypy and other tools must pass, there are multiple issues there at the moment. For example,
stubs/boltons/boltons/listutils.pyi:26: note: Superclass:
stubs/boltons/boltons/listutils.pyi:26: note: @overload
stubs/boltons/boltons/listutils.pyi:26: note: def sort(self, *, key: None = ..., reverse: bool = ...) -> None
stubs/boltons/boltons/listutils.pyi:26: note: @overload
stubs/boltons/boltons/listutils.pyi:26: note: def sort(self, *, key: Callable[[Any], Union[SupportsDunderLT[Any], SupportsDunderGT[Any]]], reverse: bool = ...) -> None
stubs/boltons/boltons/listutils.pyi:26: note: Subclass:
stubs/boltons/boltons/listutils.pyi:26: note: def sort(self) -> None
The only way to fix it is to add # type: ignore to the method definition line: def sort(self) -> None: # type: ignore
This comment has been minimized.
This comment has been minimized.
|
flake8 & mypy FIXED Time to dive into designing the correct stubs |
This comment has been minimized.
This comment has been minimized.
|
Thanks @AABur. Are you able to take a look at the stubtest errors in CI? Please say if you need guidance on any of them :) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@AABur, is this PR ready for a complete review, or do you just want help on the stubtest error for now? (I'm asking because this PR is still marked as a "draft PR" currently |
Ready for the complete review now! |
This comment has been minimized.
This comment has been minimized.
|
@AlexWaygood sorry to bother you, but it's been a week. Any chance of my PR being accepted, or will there be any constructive comments? |
|
Thanks for the ping @AABur. I haven't had a chance to have a look at this yet (we've got little bit of a backlog at the moment, and we're all volunteers!). I haven't forgotten, and I'll try to take a look soon |
|
According to mypy_primer, this change has no effect on the checked open source code. |
|
According to mypy_primer, this change has no effect on the checked open source code. |
Thanks @AABur! This looks like a good start, but there's a few things that need fixing; see my comments below.
In general, I'm a bit confused by how much commented-out code there is. Either something exists at runtime (in which case it should be included in the stub), or it doesn't. There shouldn't really be much of a need, if any, to include large chunks of commented-out code in typeshed. If you are including a large chunk of commented-out code, you need to explain why it's commented-out, or it's very confusing.
Similarly, we don't really need the # TODO: DONE comments everywhere. TODO comments are for when there's something in a file that needs more work in the future :)
|
According to mypy_primer, this change has no effect on the checked open source code. |
|
@AlexWaygood you are correct! I should have removed the comment-out code carefully before doing the PR |
|
According to mypy_primer, this change has no effect on the checked open source code. |
add stubs for boltons library