Remove LGTM references and commands#1885
Merged
Merged
Conversation
shati-patel
approved these changes
Dec 16, 2022
Contributor
shati-patel
left a comment
shati-patel
left a comment
There was a problem hiding this comment.
💥
I think you can also remove the lgtm SVGs! (We can tidy those up later though—main thing is removing the command/tests ✅ )
Contributor
Author
|
I'll do that. Also need to add a change note. |
LGTM has been decommissioned. All code and tests for downloading LGTM databases should be removed.
aeisenberg
force-pushed
the
aeisenberg/lgtm-remove
branch
from
46eda10 to
0bf1fae
Compare
Contributor
Author
|
Looks like no change note is necessary since the removal was already announced earlier. I think the behaviour was kept around behind a feature flag. I removed the svgs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LGTM has been decommissioned. All code and tests for downloading LGTM databases should be removed.
Note that there will need to be some docs changes for this to remove the docs around LGTM integration. This can happen later.
Checklist
ready-for-doc-reviewlabel there.