src: use CreateEnvironment instead of inlining its code where possible #45886
+21
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a number of places in which we created an `Environment` instance by performing each step in `CreateEnvironment` manually. Instead, just call the function itself.
|
Review requested: |
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Dec 16, 2022
joyeecheung
reviewed
Dec 16, 2022
joyeecheung
reviewed
Dec 16, 2022
addaleax
commented
Dec 16, 2022
| inspector_parent_handle.get())->impl)); | ||
| env->InitializeInspector(std::move( | ||
| static_cast<InspectorParentHandleImpl*>(inspector_parent_handle.get()) | ||
| ->impl)); |
There was a problem hiding this comment.
This is now just a clang-format leftover after addressing review comments, I’d leave it if it’s all the same to everyone.
This was referenced Dec 17, 2022
jasnell
approved these changes
Dec 19, 2022
14 tasks
legendecas
approved these changes
Dec 20, 2022
github-actions
bot
removed
the
request-ci
12 tasks
joyeecheung
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
We had a number of places in which we created an
Environmentinstance by performing each step inCreateEnvironmentmanually. Instead, just call the function itself.