Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 1: Diagram includes the non-existent "Replaced" state #1127

Open
ncoghlan opened this issue Jul 21, 2019 · 5 comments
Open

PEP 1: Diagram includes the non-existent "Replaced" state #1127

ncoghlan opened this issue Jul 21, 2019 · 5 comments

Comments

@ncoghlan
Copy link
Contributor

@ncoghlan ncoghlan commented Jul 21, 2019

I'm currently talking with a process management researcher, and asked them why their nominal process flow has a "Replaced" state in it.

Turns out they took it straight from the diagram in PEP 1: https://www.python.org/dev/peps/pep-0001/#pep-review-resolution

The "Superseded" box is labeled as "Replaced". That part of the diagram is weird anyway, as it's more likely to be Active PEPs that go to Superseded than Final ones.

@warsaw
Copy link
Member

@warsaw warsaw commented Aug 5, 2019

The "Superseded" box is labeled as "Replaced". That part of the diagram is weird anyway, as it's more likely to be Active PEPs that go to Superseded than Final ones.

I'm not sure about that. IIRC, the original intent of this was something like the RFC 822 -> 2822 -> 5822 evolution. The idea being that further refinement of an already implemented (i.e. Final) PEP would include a Superseded link back to the original PEP.

Replaces is a little weird to me. I would change that to Supersedes.

@Jamim
Copy link
Contributor

@Jamim Jamim commented Aug 6, 2019

Hello @ncoghlan and @warsaw,

I would change that to Supersedes.

Just in case, I'd like to point out that it looks like you are talking about different parts of the PEP-1.
So not only Replaces should be changed to Supersedes, but Replaced should be changed to Superseded as well.

@ncoghlan
Copy link
Contributor Author

@ncoghlan ncoghlan commented Aug 12, 2019

Yeah, there are two inconsistencies. The "Replaced" state in the diagram is just outright wrong, as there's no such state (it's called "Superseded" in the PEP text).

The fact that the fields creating those doubly linked lists of PEPs are "Replaces" and "Superseded-By" is odd, but not wrong per se.

@pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Aug 13, 2019

Are the sources for those files available in the repository?

@ncoghlan
Copy link
Contributor Author

@ncoghlan ncoghlan commented Aug 13, 2019

The png is exported from the svg at https://github.com/python/peps/blob/master/pep-0001/process_flow.svg

We don't use the svg directly due to #701

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants