Fix: applied comment directive error suppressions to program diagnostics #51777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #48850
I'm not 100% happy with with this solution.
programDiagnostics.getDiagnostics(sourceFile.fileName)is now getting called twice undergetSemanticDiagnosticsForFile:getBindAndCheckDiagnosticsForFile>getBindAndCheckDiagnosticsForFileNoCache>getMergedBindAndCheckDiagnosticsgetProgramDiagnostics...however, I'm under the impression files mostly never have more than a few program diagnostics, so the cost of computing that map should be small? If that's the case then this feels like a pretty clean solution, optimizing for the least amount of added code?