Tree Construction: do not use phase-specific handling for implied end-tag tokens emitted during InBody phase #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The
InBodyPhaseparser phase creates and processes implied close-tag tokens for a small number ofstopNameselements.This changeset updates the phase's logic so that processing of these implied tokens remains within the
InBodyparser phase.This fixes #111 by avoiding a call to the phase-specific
InTablePhase.endTagOtherto handle the implied end-tag, which as a side-effect disables theinsertFromTableflag. That flag must remainTruein order for repositioning of fostered elements relative to a<table>tag to be performed correctly.