Fix property.__set_name__ error message when arguments are invalid#4165
Merged
Conversation
jopemachine
force-pushed
the
fix-test-prop
branch
3 times, most recently
from
6035a80 to
2994e3f
Compare
youknowone
reviewed
Sep 19, 2022
Comment on lines
+165
to
+136
| format!( | ||
| "__set_name__() takes 2 positional arguments but {} were given", | ||
| arg_len | ||
| ), |
Member
There was a problem hiding this comment.
This message is common python type error which we are not handling well. We'd better to find enhance the general argument error handling instead of this way.
Member
There was a problem hiding this comment.
I am sorry, the given type is PosArgs. So no way to do it in shared code.
youknowone
force-pushed
the
fix-test-prop
branch
from
b992620 to
e325a00
Compare
Member
|
@jopemachine is it still a draft or done? |
Member
|
this seems like its good to go, no? |
youknowone
approved these changes
Feb 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.