JS: handle rephined variable in access path#11565
Merged
Merged
Conversation
asgerf
added
JS
Awaiting evaluation
asgerf
added
no-change-note-required
Contributor
Author
|
I decided not to write a change note, as it's hard to describe the circumstances that cause this to happen, and as is seen from the evaluation, those circumstances are quite rare. |
erik-krogh
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the strange behavior observed in #11488, where adding additional uses of a variable changes how it's sanitized.
Evaluation looks quiet. A few tainted nodes disappeared in a context where they are guarded by
typeof v === 'number', so this fixes some spurious flow.