Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added two new CMDi sinks fot python's stdlib #11555

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added two new CMDi sinks fot python's stdlib #11555

wants to merge 1 commit into from
+3 −1

Conversation

pwntester
Copy link
Contributor

@pwntester pwntester commented Dec 2, 2022

Adding two missing Command Injection sinks identified by @Frycos in https://frycos.github.io/vulns4free/2022/12/02/rce-in-20-minutes.html

@pwntester pwntester requested a review from a team as a code owner Dec 2, 2022
@github-actions github-actions bot added the Python label Dec 2, 2022
@pwntester
Copy link
Contributor Author

pwntester commented Dec 2, 2022

Documented here https://docs.python.org/3/library/subprocess.html#legacy-shell-invocation-functions

yoff
yoff requested changes Dec 3, 2022
View changes
Copy link
Contributor

@yoff yoff left a comment

Nice. Could you add the link (https://docs.python.org/3/library/subprocess.html#legacy-shell-invocation-functions) below line 1167 also? (Unfortunately, I cannot make a suggestion there, sorry.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoff yoff

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pwntester @yoff