Java: Cleanup imports of ExternalFlow
#11516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
java/externalflowcleanup
branch
from
480c20f to
c0ea053
Compare
michaelnebel
force-pushed
the
java/externalflowcleanup
branch
from
c715e44 to
27f2379
Compare
michaelnebel
force-pushed
the
java/externalflowcleanup
branch
2 times, most recently
from
c3cb945 to
fa5a94a
Compare
michaelnebel
force-pushed
the
java/externalflowcleanup
branch
from
fa5a94a to
6e486d4
Compare
michaelnebel
added
the
no-change-note-required
atorralba
reviewed
Dec 5, 2022
Contributor
atorralba
left a comment
atorralba
left a comment
There was a problem hiding this comment.
Mostly looks good to me, thanks for doing this! I added a couple NITs (that you can completely ignore), and one minor fix.
atorralba
approved these changes
Dec 5, 2022
Contributor
|
Wondering if this is worth a DCA run 🤔 (when it works). |
Contributor
Author
This is definitely worth a DCA run! We need to see if there are any sudden drops in performance (or improvements). |
Contributor
Author
|
DCA looks good.
Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we cleanup the bi-directional framework imports that were introduced for Models as Data.
The bi-directional imports created a huge SCC of dependencies and removing the importa revealed some missing imports in other parts of the code that were relying on the framework SCC in
ExternalFlow.qll.The code has been modified accordingly and bi-directional imports because of other abstract classes have been introduced where needed.