chore(webpack): update webpack deps for react-nativescript#10045
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
shirakaba
changed the title
rigor789
left a comment
rigor789
left a comment
There was a problem hiding this comment.
I'll apply my review suggestions - widening the ranges is important for @nativescript/webpack since it has to be able to deal with a wide variety of projects that may also pull in some of these dependencies. If we use a very strict version range, we are making it difficult to run some projects, or would cause duplicate dependencies with different versions (which is also bad, and can cause issues - webpack for instance is very sensitive to that, because it uses instanceof checks that fail if the same class was imported from a different version).
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
2 participants
PR Checklist
What is the current behavior?
Outdated deps for RNS.
What is the new behavior?
Up-to-date deps for RNS.
Fixes/Implements/Closes #[Issue Number].
I've only updated dependencies within their originally specified version range, so there should be no breaking changes.