Feat/monorepo esm#8729
Merged
NathanWalker merged 5 commits intoJul 23, 2020
Merged
Conversation
Using the @nativeclass decorator we can transform native class extensions to es5 and still keep the whole core in es2017 The same thing needs to be applied to plugins
This is simpler for now as it does not require any changes to the runtimes!
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
Collaborator
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Contributor
|
This is 🔥 @farfromrefug thank you! |
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 7, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 8, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 8, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 8, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 8, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 8, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 8, 2020
NathanWalker
pushed a commit
that referenced
this pull request
Aug 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the core to a full es2017 js build.
@NativeClassdecoratorTo apply the transformer using
tscwe need a modified version oftypescript. To do that i use ts-patch. I added it to thesetupnpm task. That's enough!Here you go with that the core is build in es2017 ...