fix(webpack): support angular 15.x#10106
Merged
Merged
Conversation
NathanWalker
previously approved these changes
Nov 26, 2022
rigor789
previously requested changes
Nov 26, 2022
Member
rigor789
left a comment
rigor789
left a comment
There was a problem hiding this comment.
We need to make this backwards compatible and check the @angular-devkit/build-angular version. The one in the package.json is a devDependency so our tests work, but in actual projects the version from the project's own package.json is used, and it might not be 15.x.
Contributor
Author
|
Thanks @rigor789! 🙂 |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f6e5971. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated to
@angular-devkit/build-angularv15.x.Please see angular/angular-cli#23936
PR Checklist
What is the current behavior?
babel-loaderthrows errors when you try building with@angular-devkit/build-angularv15.x.What is the new behavior?
No errors.