feat: clipsToBounds support by rigor789 · Pull Request #9539 · NativeScript/NativeScript

rigor789 · 2021-09-07T21:01:27Z

@farfromrefug here's a branch with the clipsToBounds changes - we had to revert them in the release branch here: 7785405

We've seen some issues with this change, some with the borders and some with boxShadow, so we'd like to step back a bit and make sure everything works as expected before we release this.

…eScript into release/8.1.0

…' on fwd navigation (#8791) Changes the behavior of android fragment transactions to use `add` instead of `replace` on forward navigation. BREAKING CHANGE: Changes the internal behavior of Android navigation: * while navigating forward, the page navigated from is not unloaded anymore * events order is changed in the sense that now `unloaded` happens after `navigatedFrom` instead of before There are multiple plus sides to this: * no more black views on navigation when using opengl (maps, ...) * navigation is faster, especially the navigation back! No longer need to recreate the page anymore. Navigation forward also gets faster as we no longer unload the previous page * navigatedFrom event happens faster * this the default behavior used by most of the android native apps

…'replace' on fwd navigation (#8791) This reverts commit e498c9d.

This reverts commit 4c547bb.

…Async (#9404)

…s set (#9447)

Fixed the incorrectly applied short form of "transform: translate" style property. closes #5202

…9110)

…ling (#9119)

)

It was unnecessary to make multiple calls requestLayout inside initNativeView (properties set)

* performance improvements around border handling BREAKING CHANGE: * if you have broder-radius or clip-path, it will clip by default

#9530

This feature needs some more work & will be included in a future version

* feat: Frame replacePage by entry * feat(webpack): improved svelte HMR (#9497) * update svelte config to use svelte-loader * handle null config * fix: worker support in .svelte files & update snapshots * fix after merge Co-authored-by: halfnelson <dpershouse@gmail.com> Co-authored-by: Igor Randjelovic <rigor789@gmail.com> * feat(webpack): use svelte-loader and fallback to svelte-loader-hot Allows running older projects * feat: allow overwriting replacePage transition Co-authored-by: farfromrefuge <martin.guillon@akylas.fr> Co-authored-by: halfnelson <dpershouse@gmail.com>

WIP - needs more work

farfromrefug · 2021-10-10T12:47:06Z

@dimitrisrk you cant use setClipToBounds as it is a rect. It wont work with rounded corners. setClipToOutline is the way to go on api >21.
@rigor789 what issue did you see? But yes clipToBounds will clip shadows. Maybe we should disable it by default (better perfs). But then what do we do on iOS?

CatchABus · 2021-10-22T21:27:46Z

@dimitrisrk you cant use setClipToBounds as it is a rect. It wont work with rounded corners. setClipToOutline is the way to go on api >21. @rigor789 what issue did you see? But yes clipToBounds will clip shadows. Maybe we should disable it by default (better perfs). But then what do we do on iOS?

I'm leaving notes as a feedback regarding this feature.

From my experience at trying to get rid of clipping in android, I have concluded that setting clipping to false for scrollable views will let their children overflow during scrolling.
I believe clipping should be true by default for such views (e.g. ListView, RadListView, ScrollView).

CatchABus · 2022-05-07T16:59:27Z

@dimitrisrk you cant use setClipToBounds as it is a rect. It wont work with rounded corners. setClipToOutline is the way to go on api >21. @rigor789 what issue did you see? But yes clipToBounds will clip shadows. Maybe we should disable it by default (better perfs). But then what do we do on iOS?

I was wondering why this PR had flaws and It seems Outline has its own limitations.

As of API 33, all Outline shapes support clipping. Prior to API 33, only Outlines that could be represented as a rectangle, circle, or round rect supported clipping.

https://developer.android.com/reference/android/graphics/Outline#canClip()

It seems that setClipToOutline will not clip paths for the time being. :(

farfromrefug · 2022-05-07T17:53:38Z

@CatchABus indeed this is why i am using clipping path (if i remember correctly)

farfromrefug and others added 30 commits August 10, 2021 13:21

feat(core): make css parsers tree-shakable (#9496)

dce7408

refactor: clean up custom flavor detection

f2b4207

chore: cleanup

7f37617

Merge branch 'release/8.1.0' of https://github.com/NativeScript/Nativ…

1608b95

…eScript into release/8.1.0

chore: fix tests for ios

fcc92f9

chore: apps webpack config

4d91db1

revert: feat(android): fragment transactions to use 'add' instead of …

ee0e5df

…'replace' on fwd navigation (#8791) This reverts commit e498c9d.

revert: fix(android): nested dialog/fragment handling (#9495)

7276c0e

This reverts commit 4c547bb.

feat(image-source): add saveToFileAsync, toBase64StringAsync & resize…

36900d7

…Async (#9404)

feat(android): vector drawable support (#9464)

490f7dc

fix(android): onSaveInstanceState should not crash when no rootView i…

ee3c4c2

…s set (#9447)

fix(styling): change transform parameters parsing (#9481)

dbaab58

Fixed the incorrectly applied short form of "transform: translate" style property. closes #5202

feat(config): added option for ignoredNativeDependencies

4cad76c

feat(color): added utilities and improved color parsing performance (#…

0ff2221

…9110)

feat: AbortController polyfill (#9333)

af281dd

chore: fix color tests

92076d4

feat: autofillType property for edit text base (#9478)

4964d31

fix(android): dont dispose fragment on onloaded (#8793)

03b7715

fix(android): make less calls to native with getters around prop hand…

bca4d95

…ling (#9119)

fix(android): prevent potential crash when app goes to background (#9347

47df889

)

chore: add guard around getLifecycle

bf2499c

fix(android): use nativeTextViewProtected internally (#9483)

71b856c

feat: requestLayout performance improvements (#9122)

e4ce17e

It was unnecessary to make multiple calls requestLayout inside initNativeView (properties set)

feat(android): support clipToBounds (#9508)

5890667

* performance improvements around border handling BREAKING CHANGE: * if you have broder-radius or clip-path, it will clip by default

chore: updated ui-mobile-base build

7e1b469

chore: 8.1.0-alpha.0

c4e9a54

chore: 8.1.0-alpha.1

66203d2

fix: css colors not parsed correctly within background property

453ea18

fix: backgroundGradient fix with android BorderDrawable

41ce315

rigor789 and others added 18 commits August 29, 2021 18:29

chore(release): webpack 5.0.0-rc.6

1bd4992

fix(ios): resiliency to frame controller viewDidDisappear

a5fd53b

chore: 8.1.0-alpha.5

bea5fd5

fix(ios): actionBar to use appearance api on ios13+ (#9530)

8e3f16d

chore: 8.1.0-alpha.6

8da66ce

fix(ios): actionBar title to use appearance api on ios15+ (#9534)

4edeb19

#9530

chore: changelog sync

05c927a

chore: 8.1.0-alpha.7

a93bab2

fix(modal): persist modal through configuration changes (#9533)

f3cd3d3

chore(release): webpack-5.0.0-rc.7

ff98985

fix: include bundle-entry-points by default

ea0b3b0

chore(release): webpack-5.0.0-rc.8

1be078f

revert: clipsToBounds support

7785405

This feature needs some more work & will be included in a future version

chore: 8.1.0-alpha.8

8ae515c

fix(ios): actionitem coloring with 15+

7e35fdf

chore: 8.1.0-rc.0

83ea056

feat: clipsToBounds support

95dd21f

WIP - needs more work

cla-bot Bot added the cla: yes label Sep 7, 2021

rigor789 changed the base branch from master to release/8.1.0 September 7, 2021 21:01

NathanWalker force-pushed the release/8.1.0 branch from 583d84a to a5b1a18 Compare September 8, 2021 23:12

Base automatically changed from release/8.1.0 to master September 10, 2021 17:52

NathanWalker force-pushed the main branch from f234056 to a11ccd8 Compare June 26, 2025 18:37

NathanWalker force-pushed the main branch from cfa3e20 to bbeca52 Compare November 4, 2025 06:15

NathanWalker force-pushed the main branch from ed43a4e to 661d607 Compare December 27, 2025 17:42

NathanWalker force-pushed the main branch from 26170f7 to 2c88a0b Compare January 4, 2026 22:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: clipsToBounds support#9539

feat: clipsToBounds support#9539
rigor789 wants to merge 59 commits into
mainfrom
feat/clipsToBounds-android

rigor789 commented Sep 7, 2021

Uh oh!

farfromrefug commented Oct 10, 2021

Uh oh!

CatchABus commented Oct 22, 2021 •

edited

Loading

Uh oh!

CatchABus commented May 7, 2022

Uh oh!

farfromrefug commented May 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

rigor789 commented Sep 7, 2021

Uh oh!

farfromrefug commented Oct 10, 2021

Uh oh!

CatchABus commented Oct 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CatchABus commented May 7, 2022

Uh oh!

farfromrefug commented May 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

CatchABus commented Oct 22, 2021 •

edited

Loading