Skip to content

feat(@schematics/angular): add guardType as an alias of implements in guard schematic #24216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

alan-agius4
Copy link
Collaborator

implements option will be removed in future in favor of guardType. This is because the implements guard pattern is deprecated in version 15.1

…` in guard schematic

`implements` option will be removed in future in favor of `guardType`. This is because the implements guard pattern is deprecated in version 15.1
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Nov 11, 2022
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 11, 2022
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Nov 11, 2022
@alan-agius4 alan-agius4 removed the request for review from atscott November 15, 2022 06:57
@atscott atscott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 2, 2022
@dgp1130 dgp1130 merged commit 5b18ce1 into angular:main Dec 5, 2022
@alan-agius4 alan-agius4 deleted the alias-type-guard branch December 5, 2022 19:10
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants