Skip to content

Resolve Project Euler 22#1224

Open
MatheusMuriel wants to merge 3 commits into
TheAlgorithms:masterfrom
MatheusMuriel:project_euler_022
Open

Resolve Project Euler 22#1224
MatheusMuriel wants to merge 3 commits into
TheAlgorithms:masterfrom
MatheusMuriel:project_euler_022

Conversation

@MatheusMuriel
Copy link
Copy Markdown
Contributor

@MatheusMuriel MatheusMuriel commented Oct 23, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu requested changes Oct 24, 2022
View reviewed changes
Comment thread Project-Euler/Problem022.js Outdated
Comment thread Project-Euler/Problem022.js Outdated
Comment thread Project-Euler/Problem022.js Outdated
Comment thread Project-Euler/Problem022.js Outdated
appgurueu
appgurueu requested changes Oct 24, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to move the names to a separate file (rather than embedding them in the code)?

@MatheusMuriel
Copy link
Copy Markdown
Contributor Author

MatheusMuriel commented Oct 24, 2022

Can you try to move the names to a separate file (rather than embedding them in the code)?

This is my first ideia, but I do know where I put this file, in the test folder? On a specific resource folder?

@appgurueu
Copy link
Copy Markdown
Collaborator

appgurueu commented Oct 25, 2022

Can you try to move the names to a separate file (rather than embedding them in the code)?

This is my first ideia, but I do know where I put this file, in the test folder? On a specific resource folder?

Test folder sounds fine to me (next to the test file).

@MatheusMuriel
Copy link
Copy Markdown
Contributor Author

MatheusMuriel commented Oct 25, 2022

Can you try to move the names to a separate file (rather than embedding them in the code)?

This is my first ideia, but I do know where I put this file, in the test folder? On a specific resource folder?

Test folder sounds fine to me (next to the test file).

Ok, I will do it

appgurueu
appgurueu reviewed Oct 29, 2022
View reviewed changes
Comment thread Project-Euler/Problem022.js
@@ -1,3 +1,5 @@
import * as fs from 'fs'
Copy link
Copy Markdown
Collaborator

@appgurueu appgurueu Oct 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just import readFileSync from fs? It seems to be the only function you need.

@stale
Copy link
Copy Markdown

stale Bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Closed due to age label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@appgurueu appgurueu appgurueu requested changes

@raklaptudirm raklaptudirm Awaiting requested review from raklaptudirm

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

stale Closed due to age

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MatheusMuriel @appgurueu