Added program for infix to postfix conversion using stack#1192
Open
Harinath-B wants to merge 7 commits into
Open
Added program for infix to postfix conversion using stack#1192Harinath-B wants to merge 7 commits into
Harinath-B wants to merge 7 commits into
Conversation
|
This pull request introduces 1 alert when merging 4f50d07 into 8c847e3 - view on LGTM.com new alerts:
|
appgurueu
requested changes
Oct 15, 2022
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
- Fix your formatting. Please also use syntactical sugar like
++or--. - No side effects. Remove calls to
console.log.
appgurueu
reviewed
Oct 16, 2022
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
Please add some more tests, with more descriptive test names
appgurueu
reviewed
Oct 20, 2022
| } | ||
|
|
||
| const priority = (op) => { | ||
| op = String(op) |
appgurueu
requested changes
Oct 20, 2022
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
Still: Please add more complex tests. Testing one simple expression and the edge case of an empty expression is good but not enough.
appgurueu
reviewed
Oct 22, 2022
| last () { | ||
| if (this.top !== -1) { | ||
| return this.stack[this.stack.length] | ||
| return this.stack[this.length()] |
Collaborator
There was a problem hiding this comment.
Does this work with 0-indexing?
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.