Kotlin: Enable java/non-serializable-field for Kotlin #11437
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It now ignores compiler-generated classes
tamasvajk
reviewed
Nov 28, 2022
The corresponding test is failing with
Executing tests in /home/runner/work/semmle-code/semmle-code/ql/java/ql/test/kotlin/query-tests/NonSerializableField.
--- expected
+++ actual
@@ -1,1 +1,1 @@
-
+| NonSerializableFieldTest.kt:3:22:3:28 | <dispatchReceiver> | This field is in a serializable class, but is not serializable itself because Foo is not serializable. |
|
Ahh, sorry for the noise, I think you might have made this PR draft, because you already noticed the above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
It now ignores compiler-generated classes