Skip to content

Adding the dependency lock file the template.#4184

Closed
16c7x wants to merge 1 commit into
github:mainfrom
16c7x:main
Closed

Adding the dependency lock file the template.#4184
16c7x wants to merge 1 commit into
github:mainfrom
16c7x:main

Conversation

@16c7x
Copy link
Copy Markdown

@16c7x 16c7x commented Nov 6, 2022

The lock file ties to an external provider dependency, it's something you'd want the option to not have under git control. https://developer.hashicorp.com/terraform/language/files/dependency-lock

Reasons for making this change:
It's a file that many would probably want to ignore.

TODO

Links to documentation supporting these rule changes:

TODO

If this is a new template:

  • Link to application or project’s homepage: TODO

The lock file ties to an external provider dependency, it's something you'd want the option to not have under git control. https://developer.hashicorp.com/terraform/language/files/dependency-lock
@lvjp
Copy link
Copy Markdown

lvjp commented Mar 29, 2023

The Lock File Location section says totally the opposite of your arguments.

You should include this file in your version control repository so that you can discuss potential changes to your external dependencies via code review, just as you would discuss potential changes to your configuration itself.

@sc250024
Copy link
Copy Markdown

sc250024 commented Apr 24, 2023

Good luck getting this merged. Seriously, I already tried: #3937 . Even with two approvals, no one would hit the Merge button :(

@16c7x 16c7x closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants