add recursion check in __call__#4213
Open
joohongpark wants to merge 1 commit into
Open
Conversation
youknowone
approved these changes
Oct 15, 2022
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
@Snowapril could you review this PR?
Snowapril
reviewed
Oct 16, 2022
Comment on lines
+257
to
+259
| vm.with_recursion("while calling a Python object", || { | ||
| vm.call_special_method(zelf.to_owned(), identifier!(vm, __call__), args) | ||
| }) |
Contributor
There was a problem hiding this comment.
Actually, in cpython, the recursion check what we inserted in this PR exist inside of _PyObject_Call. It is corresponded to invoke in our code. I'm a little bit afraid that invoke is currently used anywhere in our codes. It can make a little bit slow-down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.