switch winapi to windows in _winapi module#4086
Closed
Yaminyam wants to merge 1 commit into
Closed
Conversation
youknowone
reviewed
Aug 17, 2022
| mod _multiprocessing { | ||
| use crate::vm::{function::ArgBytesLike, stdlib::os, PyResult, VirtualMachine}; | ||
| use winapi::um::winsock2::{self, SOCKET}; | ||
| use windows::um::winsock2::{self, SOCKET}; |
Member
There was a problem hiding this comment.
Their api is not the same. manual conversion is required.
Yaminyam
changed the title
winapi to windowswinapi to windows in _winapi module
Yaminyam
changed the title
winapi to windows in _winapi modulewinapi to windows in _winapi module
Contributor
|
It may be convenient to temporarily modify |
fanninpm
reviewed
Aug 19, 2022
| strategy: | ||
| matrix: | ||
| os: [macos-latest, ubuntu-latest, windows-latest] | ||
| os: [windows-latest] |
Contributor
There was a problem hiding this comment.
Suggested change
| os: [windows-latest] | |
| os: [macos-latest, ubuntu-latest, windows-latest] |
| strategy: | ||
| matrix: | ||
| os: [macos-latest, ubuntu-latest, windows-latest] | ||
| os: [windows-latest] |
Contributor
There was a problem hiding this comment.
Suggested change
| os: [windows-latest] | |
| os: [macos-latest, ubuntu-latest, windows-latest] |
Snowapril
reviewed
Sep 17, 2022
Snowapril
reviewed
Sep 17, 2022
Snowapril
reviewed
Sep 17, 2022
Snowapril
reviewed
Sep 17, 2022
Yaminyam
force-pushed
the
fix/windows
branch
3 times, most recently
from
e96575f to
aa4f5a4
Compare
youknowone
force-pushed
the
fix/windows
branch
from
a26f761 to
050a871
Compare
youknowone
pushed a commit
to youknowone/RustPython
that referenced
this pull request
Oct 6, 2023
Copied from RustPython#4086
MannarAmuthan
pushed a commit
to MannarAmuthan/RustPython
that referenced
this pull request
Oct 7, 2023
Copied from RustPython#4086
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4078