Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloading files and folders should preserve executable bit #112099

Open
ItalyPaleAle opened this issue Dec 8, 2020 · 2 comments
Open

Downloading files and folders should preserve executable bit #112099

ItalyPaleAle opened this issue Dec 8, 2020 · 2 comments
Assignees
@lramos15
Labels
file-explorer Explorer widget issues file-io File I/O ghcs-scenario-found under-discussion Issue is under discussion for relevance, priority, approach
Milestone
Backlog

Comments

@ItalyPaleAle
Copy link
Contributor

ItalyPaleAle commented Dec 8, 2020 •
edited by bamurtaugh

Describe the bug
When you download a file from a remote (e.g. Codespaces), attributes such as the executable bit are removed. This is a (somewhat minor) annoyance when you are downloading files such as compiled binaries.

To Reproduce
Steps to reproduce the behavior with Codespaces:

  1. Within a codespace, create a file that has the executable bit set (e.g. touch foo && chmod +x foo).
  2. CMD+Click on the file and download it to your laptop
  3. The file will not have the executable bit locally so you need to run chmod +x foo again

Expected behavior
The executable bit should be preserved when downloading files.

https://github.com/microsoft/vssaas-planning/issues/1639
@isidorn isidorn self-assigned this Dec 8, 2020
@isidorn isidorn added file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach labels Dec 8, 2020
@isidorn
Copy link
Contributor

isidorn commented Dec 8, 2020

Code pointer

vscode/src/vs/workbench/contrib/files/browser/fileActions.ts

Line 1130 in 5e5ae15

operation.filesDownloaded++;

fyi @bpasero since I believe you wrote the original download code and you might have ideas.
If not I can do some investagion...

@bpasero bpasero added the file-io File I/O label Dec 9, 2020
@bpasero
Copy link
Member

bpasero commented Dec 9, 2020

@isidorn this is not possible to implement with todays file system provider API. We would need to add group/permission/executable information to file system providers (@jrieken), otherwise we cannot restore this.

Some related issues: #48659, #71204

@isidorn isidorn added this to the Backlog milestone Dec 9, 2020
@ItalyPaleAle ItalyPaleAle mentioned this issue Mar 11, 2021
Open
@drpicox drpicox mentioned this issue Jul 26, 2021
Closed
@isidorn isidorn assigned JacksonKearl and unassigned isidorn Aug 12, 2021
@lramos15 lramos15 assigned lramos15 and unassigned JacksonKearl May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lramos15 lramos15

Labels
file-explorer Explorer widget issues file-io File I/O ghcs-scenario-found under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@ItalyPaleAle @bpasero @isidorn @lramos15 @JacksonKearl @bamurtaugh