Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift: db up/downgrade scripts #11205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Swift: db up/downgrade scripts #11205

wants to merge 1 commit into from
+5,029 −1

Conversation

AlexDenisov
Copy link
Contributor

@AlexDenisov AlexDenisov commented Nov 10, 2022 •
edited

This is inspired by the ruby checks.

The scripts check is running on macOS since the first command yields no results and breaks the whole invocation.
Perhaps, xargs works differently on macOS and Linux?

codeql resolve upgrades --format=lines --allow-downgrades --additional-packs downgrades \
         --dbscheme=ql/lib/swift.dbscheme --target-dbscheme=downgrades/initial/swift.dbscheme |
         xargs codeql execute upgrades testdb

@github-actions github-actions bot added the Swift label Nov 10, 2022
@AlexDenisov AlexDenisov force-pushed the alexdenisov/swift-db-upgrades-infra branch 3 times, most recently from 3df915d to abd11e8 Compare Nov 10, 2022
redsun82
redsun82 reviewed Nov 11, 2022
View changes
Copy link
Contributor

@redsun82 redsun82 left a comment

This is inspired by the ruby checks.

The scripts check is running on macOS since the first command yields no results and breaks the whole invocation. Perhaps, xargs works differently on macOS and Linux?

codeql resolve upgrades --format=lines --allow-downgrades --additional-packs downgrades \
         --dbscheme=ql/lib/swift.dbscheme --target-dbscheme=downgrades/initial/swift.dbscheme |
         xargs codeql execute upgrades testdb

I think the problem is the behaviour of xargs when the input is empty (which is currently the case because we have no scripts 😅). By default on Linux the command is still run once with no input, and I'm guessing macOS does not run it at all (which by the way tbh seems the most sensible thing to do 🙂).

So either we wait to add at least one upgrade/downgrade script, or we add -r to skip xargs on empty.

swift/actions/database-upgrade-scripts/action.yml Outdated Show resolved Hide resolved
@AlexDenisov
Copy link
Contributor Author

AlexDenisov commented Nov 11, 2022

Right, from the man page:

     -r      Compatibility with GNU xargs.  The GNU version of xargs runs the utility argument at least once, even if xargs input is empty, and it supports a -r option to
             inhibit this behavior.  The FreeBSD version of xargs does not run the utility argument on empty input, but it supports the -r option for command-line
             compatibility with GNU xargs, but the -r option does nothing in the FreeBSD version of xargs.

@AlexDenisov AlexDenisov force-pushed the alexdenisov/swift-db-upgrades-infra branch from abd11e8 to 649953e Compare Nov 11, 2022
@AlexDenisov AlexDenisov force-pushed the alexdenisov/swift-db-upgrades-infra branch from 649953e to d49015a Compare Nov 11, 2022
@AlexDenisov AlexDenisov marked this pull request as ready for review Nov 11, 2022
@AlexDenisov AlexDenisov requested review from a team as code owners Nov 11, 2022
@AlexDenisov AlexDenisov requested a review from redsun82 Nov 11, 2022
AlexDenisov
AlexDenisov commented Nov 11, 2022
View changes
.github/workflows/swift.yml
path: swift/generated-cpp-files/**
qlformat:
Copy link
Contributor Author

@AlexDenisov AlexDenisov Nov 11, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this is most likely a rebase artifact, not sure where it comes from 🤔

Copy link
Contributor

@jketema jketema Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just a new line missing at the end of the file before this change. This adds a new line, so 114 changes.

Copy link
Contributor

@jketema jketema Nov 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming you also wanted to add a formatting check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jketema jketema

@github/codeql-ci-reviewers codeql-ci-reviewers

@redsun82 redsun82

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlexDenisov @redsun82 @jketema