feat(core): support font-variation-settings#9995
Merged
NathanWalker merged 6 commits intoNov 24, 2022
Merged
Conversation
Collaborator
|
@lekhmanrus warning the font builder was only added in API 29. if I read your changes right it will crash on < 29. |
Contributor
Author
|
@farfromrefug, Typeface.Builder added in API level 26. But yeah - I probably need to add a few conditions in the code. Thanks! |
lekhmanrus
force-pushed
the
font-variation-settings
branch
from
4424e43 to
92dc8b7
Compare
Collaborator
|
@lekhmanrus you are right. it says 26. it is weird as I am sure I saw an android doc saying 29... anyway... |
Contributor
Author
|
@farfromrefug, I guess it was Font.Builder - it says 29. But I use Typeface.Builder here. |
NathanWalker
requested changes
Nov 18, 2022
lekhmanrus
force-pushed
the
font-variation-settings
branch
from
2693b3a to
fce7851
Compare
NathanWalker
approved these changes
Nov 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
font-variation-settingsCSS rule not supported.What is the new behavior?
font-variation-settingsis supported on Android and I'm thinking about the proper implementation for iOS. I guess it should be similar to VFont - using attributes. It would be fine if someone has any suggestions/directions here. 🙂