fix(core): android refactor EditableTextBase#10052
Merged
NathanWalker merged 4 commits intoNov 24, 2022
Merged
Conversation
…change/augment delegates. also unset delegates in disposeNativeView to prevent memory leak
NathanWalker
approved these changes
Nov 24, 2022
Contributor
|
@farfromrefug Have you done anything anywhere with the mask plugin? I'm trying to make it work on ios and there is no way. It works fine on android but ios... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to allow sub classes to change/augment delegates.
also unset delegates in disposeNativeView to prevent memory leak
We used that same approach somewhere else but i dont remember where :P
Now this refactor will allow me to rewrite the input-mask plugin and have it compatible with all N features and will all components inheriting
EditableTextBaseIt should not have any consequences and i did no see any bugs. But please read the code to ensure we are all ok