New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): windows build #10056

Merged

NathanWalker merged 2 commits into NativeScript:main from lekhmanrus:windows-build

Oct 15, 2022

Contributor

lekhmanrus commented Oct 14, 2022

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the CLA.
All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

Build errors during building core package on windows.

What is the new behavior?

It works on windows as well.


          fix(core): windows build

a17604c

cla-bot bot added the cla: yes label

NathanWalker approved these changes


          Merge branch 'main' into windows-build

1ef47ad

Contributor

NathanWalker commented Oct 15, 2022

Thank you!

NathanWalker merged commit 7860d51 into NativeScript:main

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment