Included Patience Sort#1169
Open
MatheusMuriel wants to merge 2 commits into
Open
Conversation
MatheusMuriel
requested review from
appgurueu and
raklaptudirm
as code owners
appgurueu
reviewed
Oct 13, 2022
Collaborator
appgurueu
left a comment
appgurueu
left a comment
There was a problem hiding this comment.
Your implementation definitely needs some comments.
appgurueu
reviewed
Oct 13, 2022
| @@ -0,0 +1,25 @@ | |||
| import { patienceSort } from '../PatienceSort' | |||
|
|
|||
| test('The PatienceSort of the array [5, 4, 3, 2, 1] is [1, 2, 3, 4, 5]', () => { | |||
Collaborator
There was a problem hiding this comment.
Please use each: https://github.com/TheAlgorithms/TypeScript/blob/master/CONTRIBUTING.md#writing-good-tests
(side note: eventually the tests for all sorting algorithms should be consolidated as I have done in the Lua repo)
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.