C++: Split `std::string::insert` off in a separate class and do some cleanup #11212

jketema · 2022-11-10T16:03:17Z

No description provided.

`std::string::insert` returns a new iterator object and not a reference to an existing object.

jketema added 3 commits Nov 10, 2022

C++: Split std::string::insert off in a separate class

63b960d

`std::string::insert` returns a new iterator object and not a reference to an existing object.

C++: Share parameter logic in std::string model

a6f28ef

C++: Simplify getAStringParameterIndex in std::string model

eadc371

github-actions bot added the C++ label Nov 10, 2022

jketema marked this pull request as ready for review Nov 10, 2022

jketema requested a review from a team as a code owner Nov 10, 2022

jketema added the no-change-note-required This PR does not need a change note label Nov 10, 2022

C++: Split std::string::insert off in a separate class and do some cleanup #11212

Are you sure you want to change the base?

C++: Split std::string::insert off in a separate class and do some cleanup #11212

Conversation

jketema commented Nov 10, 2022

C++: Split `std::string::insert` off in a separate class and do some cleanup #11212

C++: Split `std::string::insert` off in a separate class and do some cleanup #11212