Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Telemetry query updates. #11083

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

C#: Telemetry query updates. #11083

wants to merge 7 commits into from
+58 −59

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Nov 2, 2022 •
edited

It turns out that the Telemetry we emit for API calls in C# needs to be changed.

  • We have removed the (assembly) file name as the same method can be located in different assemblies across version, which clutters the picture of the usage.
  • We have aligned the counting to only count calls and not the possible (runtime) dispatch targets.
  • We now only consider callables that are effectively public.

This should align the implemetation a bit better with Java.

@github-actions github-actions bot added the C# label Nov 2, 2022
@michaelnebel michaelnebel marked this pull request as ready for review Nov 4, 2022
@michaelnebel michaelnebel requested a review from a team as a code owner Nov 4, 2022
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github/codeql-csharp codeql-csharp

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@michaelnebel