Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin: Excluded compiler generated methods from java/confusing-method-signature #11045

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tamasvajk
Copy link
Contributor

@tamasvajk tamasvajk commented Oct 31, 2022

No description provided.

@tamasvajk tamasvajk marked this pull request as ready for review Oct 31, 2022
@tamasvajk tamasvajk requested a review from a team as a code owner Oct 31, 2022
@tamasvajk tamasvajk requested review from a team and removed request for a team Oct 31, 2022
@tamasvajk tamasvajk added the no-change-note-required This PR does not need a change note label Oct 31, 2022
@@ -137,6 +137,8 @@ private predicate delegate(Method caller, Method callee) {

from Method m, Method n, string messageQualifier
where
// Exclude compiler generated methods, such as Kotlin `$default` methods:
not m.isCompilerGenerated() and
Copy link
Contributor

@igfoo igfoo Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it would be better to do this in candidateMethod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java Kotlin no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants