Kotlin: exclude loop variables on ranges from 'unused locals' check #11032
Conversation
tamasvajk
changed the title
tamasvajk
force-pushed
the
kotlin-unused-for-loop-var
branch
from
816f99a
to
9662750
Compare
| @@ -26,5 +26,10 @@ where | |||
| not exists(getARead(v)) and | |||
| // Discarded exceptions are covered by another query. | |||
| not exists(CatchClause cc | cc.getVariable().getVariable() = v) and | |||
| // Exclude common Kotlin pattern: `for(i in x..y) { ... }` | |||
There was a problem hiding this comment.
Clarify what we're excluding? I guess not i; something synthetic instead?
There was a problem hiding this comment.
We're excluding i. I've seen the below pattern in a couple of variations:
for (i in 1..5) {
val frame = input.readFrame(Long.MAX_VALUE, 0)
... // not using i
}
There was a problem hiding this comment.
Seems like a bad pattern to me considering https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/repeat.html exists, but I guess if it happens often enough it's more likely to be noise.
There was a problem hiding this comment.
I found it a couple of times in ktor, that's why I thought I'd exclude it. Also, I don't think there's a real alternative. I haven't seen repeat before, but repeat takes a lambda (Int) -> Unit, where we wouldn't use the Int parameter, so it's the same issue. (I guess in a lambda we can use an implicit parameter, or a parameter named _, so the useless parameter check would not trigger, but in essence it's the same issue)
tamasvajk
force-pushed
the
kotlin-unused-for-loop-var
branch
from
9662750
to
b221a6a
Compare
Based on #11014.