Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: try/try! as code execution #11022

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ruby: try/try! as code execution #11022

wants to merge 2 commits into from
+47 −0

Conversation

hmac
Copy link
Contributor

@hmac hmac commented Oct 27, 2022 •
edited

Recognise Object#try(!) as a code execution. These methods are ActiveSupport extensions. Evaluation shows a slow-down for canvas-lms, but I think that's because it contains a lot of calls to try (848 vs 389 for gitlabhq). New evaluation seems fine.

@hmac hmac marked this pull request as ready for review Oct 31, 2022
@hmac hmac requested a review from a team as a code owner Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github/codeql-ruby codeql-ruby

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
documentation Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hmac