Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: Add Alamofire model to swift/cleartext-transmission #11210

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Nov 10, 2022

Add Alamofire library model to swift/cleartext-transmission. Results are disappointing at the moment, I've spent quite a bit of time trying to figure out why and I believe we need:

  • content flow through dictionaries and perhaps tuples (in progress github/codeql-c-team#1344).
  • we may need an allowImplicitRead predicate on this taint configuration.
  • flow through the HTTPHeaders class (straightforward but partially depends on the previous points).
  • in addition I believe something is going wrong specifically with the version of request that declares <Parameters: Encodable>.
  • we may also want to model AF.upload.

That's a lot, so for now I'd like to get the tests and basic coverage in.

@geoffw0 geoffw0 added the Swift label Nov 10, 2022
@geoffw0 geoffw0 requested a review from a team as a code owner Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant