Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Test improvements in preparation for new call-graph PR #11208

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Nov 10, 2022

While working on the new call graph, I improved some tests. To easier to be able to see the changes by the new call-graph, here is a PR with just these test improvements (then the total diff for the call-graph PR will only contain changes in inline-expectations)

RasmusWL added 7 commits Oct 28, 2022
And adopt argument passing tests as well.

turns out that `C.staticmethod.__func__` doesn't actually work :O
The selected edges is covered by `NormalDataflowTest.ql` now... and
reading the test-output changes in `edges` is just going to make commits
larger while not providing any real value.
I don't see the value from this, so just going to outright delete it.
(it actually stayed alive for quite some time in the original git history,
but never seemed to be that useful.)
We never had a showcase of how keyword arguments were handled
@RasmusWL RasmusWL requested a review from a team as a code owner Nov 10, 2022
Copy link
Member Author

@RasmusWL RasmusWL left a comment

ignore this review.. contained a few fixes, but I've since then squashed some commits and force pushed

RasmusWL added 4 commits Nov 10, 2022
This adds inline expectations, next commit will remove old annotations
code... but I thought it would be easier to review like this.
I ported the predicates showing difference between points-to and
type-tracking, since it's helpful to see the list of differences,
instead of having to parse expectations!
No longer needed since we're using an established testing framework now
to the new call-graph test setup. Nice that we can write `MISSING:` now!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant