Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARROW-17360: [Python] Order of columns in pyarrow.feather.read_table #14528

Merged
merged 2 commits into from Nov 9, 2022
Merged

ARROW-17360: [Python] Order of columns in pyarrow.feather.read_table #14528

merged 2 commits into from Nov 9, 2022

Conversation

AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Oct 27, 2022

This PR adds a note about the ordering of the columns in ORCFile.read().

@github-actions
Copy link

https://issues.apache.org/jira/browse/ARROW-17360

jorisvandenbossche
jorisvandenbossche reviewed Nov 9, 2022
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition looks good! Can you also add this to the read_table docstring? (a bit below in this file)

@jorisvandenbossche jorisvandenbossche merged commit 92c9f94 into apache:master Nov 9, 2022
9 of 11 checks passed
@AlenkaF AlenkaF deleted the ARROW-17360 branch November 9, 2022 11:11
@ursabot
Copy link

ursabot commented Nov 9, 2022

Benchmark runs are scheduled for baseline = 734059e and contender = 92c9f94. 92c9f94 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.07% ⬆️0.03% ⚠️ Contender and baseline run contexts do not match] test-mac-arm
[Finished ⬇️2.45% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.53% ⬆️0.07%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 92c9f942 ec2-t3-xlarge-us-east-2
[Finished] 92c9f942 test-mac-arm
[Finished] 92c9f942 ursa-i9-9960x
[Finished] 92c9f942 ursa-thinkcentre-m75q
[Finished] 734059e2 ec2-t3-xlarge-us-east-2
[Finished] 734059e2 test-mac-arm
[Finished] 734059e2 ursa-i9-9960x
[Finished] 734059e2 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Nov 9, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@mroeschke mroeschke mentioned this pull request Nov 9, 2022
Closed
3 tasks
@asfimport asfimport mentioned this pull request Nov 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Component: Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AlenkaF @ursabot @jorisvandenbossche