Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-98543: Fix asyncio.TaskGroup to not keep reference to errors after raising ExceptionGroup #98544

Merged
merged 1 commit into from Oct 22, 2022
Merged

GH-98543: Fix asyncio.TaskGroup to not keep reference to errors after raising ExceptionGroup #98544

merged 1 commit into from Oct 22, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Oct 22, 2022 •
edited by bedevere-bot

@kumaraditya303 kumaraditya303 changed the title GH-98543: Fix asyncio.TaskGroup to not keeps references to errors after raising ExceptionGroup GH-98543: Fix asyncio.TaskGroup to not keep reference to errors after raising ExceptionGroup Oct 22, 2022
gvanrossum
gvanrossum approved these changes Oct 22, 2022
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Good catch, thanks!

@gvanrossum gvanrossum merged commit f4a1494 into python:main Oct 22, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Oct 22, 2022

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@kumaraditya303 kumaraditya303 deleted the tg branch Oct 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2022
@kumaraditya303 @miss-islington
pythonGH-98543: Fix asyncio.TaskGroup to not keep reference to erro…
6cbc00b 
…rs after raising ExceptionGroup (pythonGH-98544)

(cherry picked from commit f4a1494)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@kumaraditya303 kumaraditya303 mentioned this pull request Oct 22, 2022
Closed
@gvanrossum
Copy link
Member

gvanrossum commented Oct 22, 2022

Where's the backport? Is Miss Islington confounded?

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 22, 2022 •
edited

Where's the backport? Is Miss Islington confounded?

Bedevere usually announced the presence of the backport, so I guess it's him who's confounded, not miss-islington, since miss-islington correctly created a backport here: #98550.

gvanrossum pushed a commit that referenced this pull request Oct 24, 2022
@miss-islington @kumaraditya303
[3.11] GH-98543: Fix asyncio.TaskGroup to not keep reference to err…
36d25a4 
…ors after raising ExceptionGroup (GH-98544) (#98550)

GH-98543: Fix `asyncio.TaskGroup`  to not keep reference to errors after raising ExceptionGroup  (GH-98544)
(cherry picked from commit f4a1494)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@1st1 1st1

@asvetlov asvetlov

Assignees

@gvanrossum gvanrossum

Labels
expert-asyncio needs backport to 3.11 skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kumaraditya303 @miss-islington @gvanrossum @AlexWaygood @bedevere-bot