C++: Fix getType for experimental IR dataflow#10713
Merged
MathiasVP merged 5 commits intogithub:mainfrom Oct 11, 2022
Merged
Conversation
….. n]'. This simplifies some arithmetic in a few predicates.
…t ever used for dataflow, and it should give us a slight speedup.
…compatible with the old AST library.
jketema
reviewed
Oct 11, 2022
Contributor
jketema
left a comment
jketema
left a comment
There was a problem hiding this comment.
The first two commits LGTM. Related to the third commit I've one question below. I also have trouble wrapping my head around the GLValue stuff and Type0, so I think I need a voiceover for those.
cpp/ql/lib/experimental/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
Show resolved
Hide resolved
jketema
reviewed
Oct 11, 2022
cpp/ql/lib/experimental/semmle/code/cpp/ir/dataflow/internal/DataFlowUtil.qll
Outdated
Show resolved
Hide resolved
… in 'PostUpdateNode'.
…rename 'getType0' to 'getTypeImpl' to avoid confusion.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
IRTypewithTypein the IR-based use-use dataflow library. This change is needed to remain compatible with thegetTypein the old AST-based dataflow library. And in fact, I think using Type here makes more sense since this is often the type people want to use for dataflow queries.The main point of this PR is done in the last commit. The first commit is a refactoring PR that should be behavior-preserving, and the second commit is a slight performance change that reduces the number of dataflow nodes generated from IR operands.