Ruby: remove public abstract classes for Action{View,Controller}#10673
Merged
Conversation
alexrford
reviewed
Oct 4, 2022
alexrford
left a comment
alexrford
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this - just a question around the deprecation policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these were abstract because we provide separate implementations for calls in the context of ActionView and ActionController. In those cases, I've moved the public-facing class to
Rails.qll, introducedImpl(range) classes for them ininternal/Rails.qll, and kept theImplsubclasses as private classes in the appropriateActionView.qllandActionController.qllfile.I've also moved the
this.getMethodName() = ...restrictions out of the base class charpreds and into the individual implementation charpreds. This adds a little more duplication, but I have a reason for doing it: when I add ActionMailer support, I'll want a call tomailto be considered aRenderCall, sothis.getMethodName() = "render"in the base class would not work.