Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query for tainted wordexp calls. #10077

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

intrigus-lgtm
Copy link
Contributor

@intrigus-lgtm intrigus-lgtm commented Aug 16, 2022

This is my first query for C/C++ I think, so there is likely some improvement possible.

@intrigus-lgtm
Copy link
Contributor Author

intrigus-lgtm commented Aug 16, 2022

This is inspired by syoyo/tinygltf#368.
Sadly, my query can not find that specific instance.
The taint seems to get lost in LoadFromString around lines 5648.
LoadFromString -> ParseBuffer -> LoadExternalFile -> FindFile -> fs->ExpandFilePath (ExpandFilePathFunction) -> ExpandFilePath (line 2611) -> wordexp (line 2640)

(The used database is from https://lgtm.com/projects/g/syoyo/tinygltf/ci/#ql)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants