docs: fix linter errors for ajs-quick-reference page. by regulas1 · Pull Request #47635 · angular/angular

regulas1 · 2022-10-05T08:28:58Z

This addresses a part of the issue
#47179

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

This addresses a part of the issue #47179

jessicajaniuk · 2022-10-05T18:25:21Z

@regulas1 This change looks good, but looks like you'll need to rebase. CI is failing to run due to being behind.

bob-watson

Thanks for tackling this--especially for your first PR!
This is a particularly challenging topic because it contains terms from AngularJS as well as Angular. As such, trying to make the linter happy is difficult. Nevertheless, you were able to get rid of quite a few errors!

I left a few comments and suggestions below.

Also, don't forget to update the @reviewed date!

Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com>

bob-watson · 2022-10-06T11:56:08Z

Thanks for the update!
Please see the comment in the reopened comment.

Also, after you make that change, could you squash the commits into a single commit? With that, we'll be able to merge this.

Thanks, again for your contribution!

jessicajaniuk · 2022-10-07T18:06:32Z

@regulas1 Looks like you've merged main into your branch instead of rebasing and squashing. It seems to be causing issues with CI and conflicts. Can you fix that?

regulas1 · 2022-10-07T19:10:13Z

@regulas1 Looks like you've merged main into your branch instead of rebasing and squashing. It seems to be causing issues with CI and conflicts. Can you fix that?

Yes I will fix that. Apologies.

bob-watson

LGTM.

Please squash the commits into a single commit with a commit messages that starts with docs:

Thanks!

This addresses a part of the issue #47179 Update aio/content/guide/ajs-quick-reference.md Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com> Update aio/content/guide/ajs-quick-reference.md Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com> Update aio/content/guide/ajs-quick-reference.md Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com> Update aio/content/guide/ajs-quick-reference.md Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com> Update aio/content/guide/ajs-quick-reference.md Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com> Update aio/content/guide/ajs-quick-reference.md Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com> Update aio/content/guide/ajs-quick-reference.md Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com>

1�747536) Adds the logic that will filter out unexposed inputs/outputs and apply the aliases that the author specified when writing the host directives. PR Close #47536

PR Close #47688

Previously we built DevTools for all browsers with version 2 of the manifest file format. This commit includes a number of refactors and API additions that will enable us to build DevTools with version 3 of the manifest file format. The manifest v3 build of Angular DevTools has been tested on Chrome, Edge, and Safari. Notably, the Firefox version of Angular DevTools remains as a manifest v2 build. Firefox does not yet support manifest v3 in it's latest stable release. When Firefox makes this transition, a follow up PR will update the Firefox manifest file to version 3. Because Firefox still needs v2, we need to keep some old v2 APIs around in our background page (service worker in v3) that will execute conditionally based on if the extension was built for v2 or v3. This is determined with the chrome.runtime.getManifest().manifest_version API. PR Close #47575

PR Close #47708

See associated pull request for more information. PR Close #47711

See associated pull request for more information. PR Close #47551

See associated pull request for more information. PR Close #47376

PR Close #47704

Add a new boolean attribute to NgOptimizedImage called `fill` which does the following: * Removes the requirement for height and width * Adds inline styling to cause the image to fill its containing element * Adds a default `sizes` value of `100vw` which will cause the image to have a responsive srcset automatically generated PR Close #47738

With this change we add a missing period to the error message. PR Close #47744

Update labels as part of standardization PR Close #47747

Update to the latest version of the feature triage action

Updates all of the comp: * labels to area: * instead PR Close #47750

Update to the latest version of the action

1�77735) Wire up new github action for identifying g3-affecting PRs. PR Close #47735

This update describes the content authoring and revision process in sufficient detail for technical and non-technical contributors to the angular.io documentation. PR Close #47381

…rs` (#47758) This commit updates the `provideHttpClient` function to return the `EnvironmentProviders` instead of a regular `Provider[]`, to make sure that the `provideHttpClient` can only be used where an environment is being setup. PR Close #47758

Separated HTML elements with judicious use of space. It not only makes it easier to read the HTML; it also makes it consistent with the formatting of https://github.com/angular/angular/edit/main/aio/content/examples/what-is-angular/src/app/hello-world-bindings/hello-world-ngif.component.html. PR Close #47331

…tom implementation (#47678) The supported Node.js versions for the `@angular/compiler-cli` package (^14.15.0 || >=16.10.0) allow for the use of the `recursive` option of `mkdirSync`. Using the `recursive` option removes the need to manually create each subdirectory in a given path. PR Close #47678

1�71/angular into DocumentationUpdate47179

jessicajaniuk · 2022-10-17T08:22:56Z

@regulas1 You will have to rebase and fix your commit history on this PR. You've merged changes from upstream/main rather than rebasing, and that's brought in a ton of extra commits. Please either rebase and squash or close and recreate a new clean PR.

regulas1 · 2022-10-17T08:57:50Z

Sorry about that trying to fix it, Ill create a new PR

angular-automatic-lock-bot · 2022-11-17T16:06:14Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

docs: fix linter errors for ajs-quick-reference page.

84fb3fc

This addresses a part of the issue #47179

pullapprove Bot requested a review from jessicajaniuk October 5, 2022 08:29

angular-robot Bot added the comp: docs label Oct 5, 2022

ngbot Bot added this to the Backlog milestone Oct 5, 2022

jessicajaniuk added target: patch This PR is targeted for the next patch release action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 5, 2022

bob-watson added the aio: preview label Oct 6, 2022

bob-watson self-requested a review October 6, 2022 00:59

bob-watson suggested changes Oct 6, 2022

View reviewed changes

regulas1 and others added 8 commits October 6, 2022 20:52

Update aio/content/guide/ajs-quick-reference.md

ab233a4

Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com>

Update aio/content/guide/ajs-quick-reference.md

239e8ef

Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com>

Update aio/content/guide/ajs-quick-reference.md

518bb6d

Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com>

Update aio/content/guide/ajs-quick-reference.md

b82cf31

Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com>

Update aio/content/guide/ajs-quick-reference.md

f0c25bc

Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com>

Update aio/content/guide/ajs-quick-reference.md

e42d7a0

Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com>

Update aio/content/guide/ajs-quick-reference.md

015303f

Co-authored-by: Bob Watson <104218420+bob-watson@users.noreply.github.com>

Merge branch 'angular:main' into DocumentationUpdate47179

92b785c

regulas1 added 2 commits October 7, 2022 04:13

Added Filter and pipes to build documentation

ae10c7c

Merge branch 'main' into DocumentationUpdate47179

0b6ea94

regulas1 added 2 commits October 11, 2022 07:45

updated ngModel

c383686

Merge branch 'angular:main' into DocumentationUpdate47179

af3e3db

bob-watson suggested changes Oct 11, 2022

View reviewed changes

bob-watson added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 11, 2022

regulas1 and others added 3 commits October 15, 2022 23:14

Merge branch 'angular:main' into DocumentationUpdate47179

9ad7f84

refactor(core): add input and output filtering for host directives (# 1�7

a15fb2b

1�747536) Adds the logic that will filter out unexposed inputs/outputs and apply the aliases that the author specified when writing the host directives. PR Close #47536

dsnoeijer and others added 22 commits October 16, 2022 21:26

docs: fix linter errors for security.md (#47688)

c18dfcc

PR Close #47688

docs: fix linter errors for what-is-angular.md (#47708)

8b77ae5

PR Close #47708

build: update dependency @rollup/plugin-commonjs to v23 (#47711)

ed20073

See associated pull request for more information. PR Close #47711

build: update all non-major dependencies (#47551)

7f9b574

See associated pull request for more information. PR Close #47551

build: update io_bazel_rules_sass digest to f6ceac7 (#47376)

e8dfbf3

See associated pull request for more information. PR Close #47376

docs: add Joshua Morony to GDE resources (#47704)

194d64e

PR Close #47704

fix(compiler-cli): add missing period to error message (#47744)

02b5de6

With this change we add a missing period to the error message. PR Close #47744

build: update labels to match standardized labels (#47747)

f257f5f

Update labels as part of standardization PR Close #47747

build: update to the latest version of the feature triage action

bb7a86c

Update to the latest version of the feature triage action

docs: release notes for the v14.2.6 release

6cb8ccc

build: update comp labels to be area instead (#47750)

7427955

Updates all of the comp: * labels to area: * instead PR Close #47750

release: bump the next branch to v15.1.0-next.0

5707913

docs: release notes for the v15.0.0-next.6 release

74e6ee0

build: update commit message based labels action

c1bd69f

Update to the latest version of the action

build: wire up new github action for identifying g3-affecting PRs (#4 1�7

be8b3e0

1�77735) Wire up new github action for identifying g3-affecting PRs. PR Close #47735

docs: update of documentation contrib. guide (#47381)

d7752a1

This update describes the content authoring and revision process in sufficient detail for technical and non-technical contributors to the angular.io documentation. PR Close #47381

Merge branch 'DocumentationUpdate47179' of https://github.com/regulas 1�7

848e2f7

1�71/angular into DocumentationUpdate47179

angular-robot Bot added detected: breaking change PR contains a commit with a breaking change detected: deprecation PR contains a commit with a deprecation detected: feature PR contains a feature commit labels Oct 16, 2022

regulas1 closed this Oct 17, 2022

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: fix linter errors for ajs-quick-reference page.#47635

docs: fix linter errors for ajs-quick-reference page.#47635
regulas1 wants to merge 135 commits into
angular:mainfrom
regulas1:DocumentationUpdate47179

regulas1 commented Oct 5, 2022

Uh oh!

jessicajaniuk commented Oct 5, 2022

Uh oh!

bob-watson left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bob-watson commented Oct 6, 2022

Uh oh!

jessicajaniuk commented Oct 7, 2022

Uh oh!

regulas1 commented Oct 7, 2022

Uh oh!

bob-watson left a comment

Uh oh!

jessicajaniuk commented Oct 17, 2022

Uh oh!

regulas1 commented Oct 17, 2022

Uh oh!

angular-automatic-lock-bot Bot commented Nov 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

regulas1 commented Oct 5, 2022

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

jessicajaniuk commented Oct 5, 2022

Uh oh!

bob-watson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bob-watson commented Oct 6, 2022

Uh oh!

jessicajaniuk commented Oct 7, 2022

Uh oh!

regulas1 commented Oct 7, 2022

Uh oh!

bob-watson left a comment

Choose a reason for hiding this comment

Uh oh!

jessicajaniuk commented Oct 17, 2022

Uh oh!

regulas1 commented Oct 17, 2022

Uh oh!

angular-automatic-lock-bot Bot commented Nov 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants