build(bazel): some cleanup tasks by kormide · Pull Request #47632 · angular/angular

kormide · 2022-10-05T05:14:03Z

@devversion @josephperrott @gregmagolan

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the new behavior?

Updated CLI sources version to match with main, removed some unused package.json scripts.

Does this PR introduce a breaking change?

Yes
No

kormide · 2022-10-07T01:47:38Z

This fixes a regression caused by 92a06f7#diff-077dd6145fe7c7d7e36918be05c1ccac4aa3393ff98f743feaa0730ea2d86b6aR7.

Basically, the realX properties are undefined when the doc is outside of packages/, e.g., a doc inside of /aio/content. projectRelativePath doesn't do any resolution so it's always defined, causing some files to get the pacakges/ prefix that shouldn't.

Nice catch. Capturing this here for the future. Even though this is in the angular-api-package- there is aio/content files processed. These don't use the TS processor and therefore are not scoped to the /packages base path. Non TS files do not have the realFilePath property: https://github.com/angular/dgeni-packages/blob/9dfdd284c09776a48b5eae031441d410de556192/base/processors/read-files.js#L99-L100.

kormide · 2022-10-07T02:01:36Z

Because dgeni needs to be able to walk angular's node_modules tree to resolve typescript types, I had to add no-remote-exec because we're going over the RBE limit. Limit is 70,000 and this puts it at ~96000.

In the components repo we are just doing this explicitly. Can we do this here too? https://github.com/angular/components/blob/main/src/BUILD.bazel#L34-L39

I believe you should be able to fine-grain select dependencies which are relevant for the TS API doc generation-like we do in the components repo.

Good call. Turns out I only needed

"@npm//rxjs", "@npm//@types/node",

devversion · 2022-10-10T12:18:16Z

I believe you should be able to fine-grain select dependencies which are relevant for the TS API doc generation-like we do in the components repo.

devversion · 2022-10-10T12:24:41Z

Sorry, I feel like I keep asking on this symlinking stuff but I want to be sure we capture this in the relevant spots. Why do we need to follow symlinks for these files but not for the other generated files? Especially if we use copy_to_bin? Isn't everything a symlink in the runfiles directory?

This stuff can be captured in the commit messages too

I'm not exactly sure why these assets were failing to load on Windows. @alan-agius4 pointed me to this fix and it seemed to just work.

I want to double check why it's not needed for the other folders, or at least what makes the cases different. I'll do that and I'll try to write a better comment.

I looked into this a bit further.

The assets are layed out in the symlink tree the same way on all platforms: asset (source) files are symlinks, laid out in real folders.

Something different about the assets below these ones, stackblitz/generated, example-zips/generates etc. is that these are directory artifacts, so the folder itself is a symlink to the output tree but then all of the files are real.

For whatever reason, architect on Windows has issues following symlinks to files but not symlinked directories to real files. I checked to see whether this was related to the "serve" target using assets from the source tree rather than the copied-to-bin version, but it's the same result.

So this may just be an architect issue (fyi @alan-agius4 ), or just an issue with Windows symlinks behaving differently.

@devversion I'll improve the comment but are you okay with this workaround for now?

devversion · 2022-10-10T12:34:16Z

Nice catch. Capturing this here for the future. Even though this is in the angular-api-package- there is aio/content files processed. These don't use the TS processor and therefore are not scoped to the /packages base path. Non TS files do not have the realFilePath property: https://github.com/angular/dgeni-packages/blob/9dfdd284c09776a48b5eae031441d410de556192/base/processors/read-files.js#L99-L100.

ngbot · 2022-10-20T18:45:41Z

I see that you just added the action: merge label, but the following checks are still failing:
     status "ci/circleci: test_aio_local" is failing
     missing required labels: target: *
     status "pullapprove" is pending
     missing required status "google-internal-tests"
     1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

It was out of date with the current legacy build

No longer needed after the migration

Windows Added "followSymlinks" blocks on the assets.

Add the hack to a central location so that it's easier to fix later.

rules_nodejs released a fix for the RUNFILES issue.

Fixes the 'Export has no declarations: unknown' warning and unresolved type warnings.

written Incorrectly prepended 'packages/' to docs that were under aio/content.

Caused by chromium debug logs in @angular/build-tooling.

Some earlier refactoring prevented the watchr script from running in the source tree. There was also a Windows issue where running architect didn't preserve symlinks causing the app to not be served.

angular-automatic-lock-bot · 2022-11-20T16:06:08Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

pullapprove Bot requested review from AndrewKushnir and devversion October 5, 2022 05:14

jessicajaniuk added the area: bazel Issues related to the published `@angular/bazel` build rules label Oct 6, 2022

ngbot Bot added this to the Backlog milestone Oct 6, 2022

kormide force-pushed the aio-bazel-cleanup branch 2 times, most recently from 6140579 to 4c38e68 Compare October 7, 2022 01:45

kormide commented Oct 7, 2022

View reviewed changes

kormide force-pushed the aio-bazel-cleanup branch from 4c38e68 to ac89362 Compare October 7, 2022 02:00

kormide commented Oct 7, 2022

View reviewed changes

devversion approved these changes Oct 10, 2022

View reviewed changes

devversion force-pushed the aio-bazel-migration branch from 268ba4c to 668e6d1 Compare October 10, 2022 13:09

pullapprove Bot requested review from JiaLiPassion, alan-agius4, alxhub, jelbourn, josephperrott and pkozlowski-opensource October 10, 2022 16:44

kormide force-pushed the aio-bazel-cleanup branch 2 times, most recently from 5339d16 to 394709f Compare October 10, 2022 20:21

kormide force-pushed the aio-bazel-cleanup branch 2 times, most recently from 2f7362a to d422210 Compare October 18, 2022 19:23

kormide requested review from devversion and removed request for AndrewKushnir, JiaLiPassion, alan-agius4, alxhub, jelbourn, josephperrott and pkozlowski-opensource October 18, 2022 19:23

pullapprove Bot requested a review from AndrewKushnir October 18, 2022 19:24

devversion approved these changes Oct 20, 2022

View reviewed changes

kormide added the action: merge The PR is ready for merge by the caretaker label Oct 20, 2022

devversion added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Oct 20, 2022

kormide force-pushed the aio-bazel-cleanup branch from f245ca9 to feac689 Compare October 20, 2022 19:00

kormide added 9 commits October 20, 2022 12:01

build(bazel): update CLI sources ref for aio build

ea004fd

It was out of date with the current legacy build

build(bazel): remove unused AIO package.json scripts

c8bbf08

No longer needed after the migration

build(bazel): fix an AIO bug where symlinked assets were not loaded on

4e66ade

Windows Added "followSymlinks" blocks on the assets.

build(bazel): consolidate windows chromium path workaround

bd45eb5

Add the hack to a central location so that it's easier to fix later.

build(bazel): update rnj and remove launcher patch

df24ee1

rules_nodejs released a fix for the RUNFILES issue.

build(bazel): fix missing dgeni dependencies

fcb3085

Fixes the 'Export has no declarations: unknown' warning and unresolved type warnings.

build(bazel): fix a regression where github links were incorrectly

9f79eb4

written Incorrectly prepended 'packages/' to docs that were under aio/content.

build(bazel): fix remote cache missses on Windows and OSX

f898056

Caused by chromium debug logs in @angular/build-tooling.

build(bazel): fix regressions for docs-watch

be3e19c

Some earlier refactoring prevented the watchr script from running in the source tree. There was also a Windows issue where running architect didn't preserve symlinks causing the app to not be served.

kormide force-pushed the aio-bazel-cleanup branch from feac689 to be3e19c Compare October 20, 2022 19:02

kormide added the action: merge The PR is ready for merge by the caretaker label Oct 20, 2022

devversion merged commit d34b4c1 into angular:aio-bazel-migration Oct 20, 2022

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 20, 2022

Conversation

kormide commented Oct 5, 2022

PR Checklist

PR Type

What is the new behavior?

Does this PR introduce a breaking change?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kormide Oct 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ngbot Bot commented Oct 20, 2022

Uh oh!

angular-automatic-lock-bot Bot commented Nov 20, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kormide Oct 18, 2022 •

edited

Loading