Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS/Python/Ruby: s/a HTML/an HTML/ #10641

Merged
merged 1 commit into from Sep 30, 2022
Merged

JS/Python/Ruby: s/a HTML/an HTML/ #10641

merged 1 commit into from Sep 30, 2022

Conversation

nickrolfe
Copy link
Contributor

@nickrolfe nickrolfe commented Sep 30, 2022

HTML is universally pronounced beginning with a vowel-sound, so "a HTML" sounds wrong and weird.

This started with fixing the alert message for IncompleteMultiCharacterSanitizationQuery.qll in JavaScript and Ruby, but then I also fixed the places that showed up in a search (restricted to the dynamic language directories) for "a HTML".

@nickrolfe nickrolfe changed the title JS/Ruby: s/a HTML/an HTML/ JS/Python/Ruby: s/a HTML/an HTML/ Sep 30, 2022
@nickrolfe nickrolfe marked this pull request as ready for review Sep 30, 2022
@nickrolfe nickrolfe requested review from a team as code owners Sep 30, 2022
@nickrolfe nickrolfe added the no-change-note-required This PR does not need a change note label Sep 30, 2022
tausbn
tausbn approved these changes Sep 30, 2022
Copy link
Contributor

@tausbn tausbn left a comment

Wait... Are you saying I shouldn't be pronouncing "HTML" as "Hut-mill"?

@nickrolfe
Copy link
Contributor Author

nickrolfe commented Sep 30, 2022

How about… HoTMaiL?

@nickrolfe nickrolfe merged commit ef8ec08 into main Sep 30, 2022
30 of 31 checks passed
@nickrolfe nickrolfe deleted the nickrolfe/a_an branch Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants