Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perimeter Calculator #3247

Merged
merged 6 commits into from Sep 8, 2022
Merged

Perimeter Calculator #3247

merged 6 commits into from Sep 8, 2022

Conversation

poorvadiwan
Copy link
Contributor

@poorvadiwan poorvadiwan commented Sep 2, 2022

I went through the Maths section of the repository and found programs for volume and area but not perimeter. So this is a program to calculate perimeter of geometrical objects.

  • Add an algorithm?

  • I have read CONTRIBUTING.md.

  • This pull request is all my own work -- I have not plagiarized.

  • All functions and variable names follow Java naming conventions.

@poorvadiwan poorvadiwan requested review from siriak and yanglbme as code owners Sep 2, 2022
Copy link
Member

@siriak siriak left a comment

Please also add some JUnit tests

@poorvadiwan
Copy link
Contributor Author

poorvadiwan commented Sep 7, 2022

I have completed the changes you asked!!
I apologize for the mess, actually, I am new to GitHub so I was a bit confused.

siriak
siriak approved these changes Sep 8, 2022
Copy link
Member

@siriak siriak left a comment

Looks good, thanks!

@siriak siriak merged commit 1e4c4a1 into TheAlgorithms:master Sep 8, 2022
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants