Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Issue Reporter window in taskbar (#130497) #156141

Merged
merged 1 commit into from Aug 1, 2022

Conversation

gjsjohnmurray
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Jul 25, 2022

This PR fixes #130497

Issue Reporter window now shows in the taskbar.

@gjsjohnmurray
Copy link
Contributor Author

gjsjohnmurray commented Jul 25, 2022

/assign @TylerLeonhardt

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jul 28, 2022

Hmm this doesn't seem to do anything on macOS. @bpasero any thoughts?

@bpasero
Copy link
Member

bpasero commented Jul 29, 2022

macOS does not show multiple windows in the taskbar, does it?

@gjsjohnmurray
Copy link
Contributor Author

gjsjohnmurray commented Jul 29, 2022

On macOS does Issue Reporter now appear in the Command+Tab switcher? Was it there even before this PR?

@bpasero
Copy link
Member

bpasero commented Jul 29, 2022

macOS behaves different for window management compared to Windows or Linux. Neither do individual windows appear in the Cmd+Tab switcher nor do they appear as individual entries in the task bar.

@gjsjohnmurray
Copy link
Contributor Author

gjsjohnmurray commented Jul 29, 2022

On macOS can a user lose sight of the Issue Reporter window (e.g. when gathering information from other windows) and then have difficulty finding it again? That's what this PR addresses for Windows users.

@bpasero
Copy link
Member

bpasero commented Jul 29, 2022

Me as macOS user never felt I would loose any windows. I do not think this issue is specific to VSCode, that is just how all macOS apps work?

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Jul 29, 2022

Yeah I agree with @bpasero. As a macOS user I never find this to be a problem. Since there doesn't seem to be any affect on macOS but this does help Windows, I don't mind merging this in..... but since it's Friday before the release, I will push this to next month so we can let it sit in Insiders.

@TylerLeonhardt TylerLeonhardt added the issue-reporter Issue reporter widget issues label Jul 29, 2022
@TylerLeonhardt TylerLeonhardt added this to the August 2022 milestone Jul 29, 2022
@TylerLeonhardt TylerLeonhardt merged commit f9bee28 into microsoft:main Aug 1, 2022
9 checks passed
@gjsjohnmurray gjsjohnmurray deleted the fix-130497 branch Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue-reporter Issue reporter widget issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants