Skip to content

Ruby: Treat ActiveRecord::Base.create as a model instantiation#10338

Merged
hmac merged 5 commits into
github:mainfrom
hmac:hmac/ar-model-create
Sep 29, 2022
Merged

Ruby: Treat ActiveRecord::Base.create as a model instantiation#10338
hmac merged 5 commits into
github:mainfrom
hmac:hmac/ar-model-create

Conversation

@hmac
Copy link
Copy Markdown
Contributor

@hmac hmac commented Sep 7, 2022

Calls such as Post.create are now recognised as model instantiations.

Evaluation shows no noticeable change (good or bad).

@github-actions github-actions Bot added the Ruby label Sep 7, 2022
@hmac hmac force-pushed the hmac/ar-model-create branch from a0210aa to 727a2b2 Compare September 7, 2022 15:30
@github-actions github-actions Bot added the Kotlin label Sep 7, 2022
@hmac hmac force-pushed the hmac/ar-model-create branch from 727a2b2 to cad24c7 Compare September 7, 2022 15:31
@github-actions github-actions Bot removed the Kotlin label Sep 7, 2022
@hmac hmac force-pushed the hmac/ar-model-create branch 2 times, most recently from 970445b to bddc263 Compare September 26, 2022 22:06
@hmac hmac marked this pull request as ready for review September 26, 2022 22:20
@hmac hmac requested a review from a team as a code owner September 26, 2022 22:20
@hmac hmac force-pushed the hmac/ar-model-create branch from 0017b80 to 0e5aa97 Compare September 28, 2022 20:25
Copy link
Copy Markdown
Contributor

@alexrford alexrford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hmac hmac merged commit fa2d84c into github:main Sep 29, 2022
@hmac hmac deleted the hmac/ar-model-create branch September 29, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants