Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Added a note about Github Codespaces' warning #44148

Merged
merged 6 commits into from Jan 21, 2022
Merged

[ci skip] Added a note about Github Codespaces' warning #44148

merged 6 commits into from Jan 21, 2022

Conversation

azzenabidi
Copy link
Contributor

@azzenabidi azzenabidi commented Jan 11, 2022

Summary

This edit should clarify any confusion around a persistent warning when setting up Github Codespaces to contribute to the Rails Framework.

Other Information

Related discussion: https://discuss.rubyonrails.org/t/issues-with-github-codespaces-setup-to-contribute-to-rails/79731

@rails-bot rails-bot bot added the docs label Jan 11, 2022
@yahonda
Copy link
Member

yahonda commented Jan 18, 2022

Both delayed_job 4.1.10 and delayed_job_active_record 4.1.7 support Rails 7.
Then "Your lockfile doesn't include a valid resolution." warnings will disappear by following these steps.

  • Command to update delayed_job delayed_job_active_record gems
bundle update delayed_job delayed_job_active_record --conservative
bundle install
  • Before running bundle update delayed_job delayed_job_active_record --conservative
$ bundle install
... snip ...
Using websocket-client-simple 0.3.0 from https://github.com/matthewd/websocket-client-simple.git (at close-race@e161305)
Your lockfile doesn't include a valid resolution.
You can fix this by regenerating your lockfile or trying to manually editing the bad locked gems to a version that satisfies all dependencies.
The unmet dependencies are:
* activesupport (>= 3.0, < 6.2), depended upon delayed_job-4.1.9, unsatisfied by activesupport-7.1.0.alpha
* activerecord (>= 3.0, < 6.2), depended upon delayed_job_active_record-4.1.6, unsatisfied by activerecord-7.1.0.alpha
Bundle complete! 77 Gemfile dependencies, 217 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
  • After running bundle update delayed_job delayed_job_active_record --conservative
$ bundle install
... snip ...
Using websocket-client-simple 0.3.0 from https://github.com/matthewd/websocket-client-simple.git (at close-race@e161305)
Bundle complete! 77 Gemfile dependencies, 217 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.

Refer to these commits for detail.
collectiveidea/delayed_job@8b6fd4b
collectiveidea/delayed_job_active_record@7bd1abb

@azzenabidi
Copy link
Contributor Author

azzenabidi commented Jan 18, 2022

@yahonda Thanks! I will update the PR accordingly.

@azzenabidi
Copy link
Contributor Author

azzenabidi commented Jan 20, 2022

@yahonda thanks! done :)

@rafaelfranca
Copy link
Member

rafaelfranca commented Jan 20, 2022

Instead of merging this we should just upgrade those gems in the Gemfile.lock. Can you change the PR to upgrade those gems?

@azzenabidi
Copy link
Contributor Author

azzenabidi commented Jan 20, 2022

@rafaelfranca done :)

@yahonda
Copy link
Member

yahonda commented Jan 20, 2022

This pull request should update Gemfile.lock file only. updating yarn.lock is out of this pull request scope.

@rafaelfranca rafaelfranca merged commit 3f13828 into rails:main Jan 21, 2022
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants