gh-96711: Do not print debug information upon Invalid opcode #96712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
serge-sans-paille
commented
Sep 9, 2022
•
- Issue: Debug message printed in release mode upon invalid Opcode #96711
|
cc @vstinner :-) |
vstinner
reviewed
Sep 19, 2022
serge-sans-paille
force-pushed
the
fix/cleanup-unknown-opcode
branch
4 times, most recently
from
2c662a3
to
32e4640
Compare
|
@vstinner : as green as a clover :-) |
vstinner
reviewed
Sep 19, 2022
vstinner
reviewed
Sep 19, 2022
serge-sans-paille
force-pushed
the
fix/cleanup-unknown-opcode
branch
4 times, most recently
from
c64cba3
to
c1f15ec
Compare
… Invalid opcode Also add code to test that path. Fix python#96711
serge-sans-paille
force-pushed
the
fix/cleanup-unknown-opcode
branch
from
c1f15ec
to
e3b85d8
Compare
|
Merged, thanks @serge-sans-paille. It's good that all data are now available to the caller in the exception message directly, it's more convenient than having to deal with stderr. IMO it's an enhancement, not a bugfix, so I will not backport the change to Python 3.11 and older versions. |
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.