gh-96624: Fix test_dotted_but_module_not_loaded in testpatch.py #96691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sweeneyde
changed the title
sweeneyde
added
the
|
If you want to schedule another build, you need to add the " |
bedevere-bot
removed
the
|
All of the refleak buildbots that ran no longer have the warnings about failing and re-trying test_unittest. Unfortunately, they all emit at least one other warning (#96696), so they're still "orange", not green. |
ezio-melotti
approved these changes
Sep 9, 2022
LGTM.
This seems to reflect better the original meaning of the code before c735d54,
Specifically this bit: c735d54#diff-a166f2dc69b03117686d52e8c67698b174f612d6e57c692a74d5f4cce1798c84L1922-L1926
# make sure it's there
- import unittest.test.testmock.support
+ import test.test_unittest.testmock.support
# now make sure it's not:
with patch.dict('sys.modules'):
- del sys.modules['unittest.test.testmock.support']
- del sys.modules['unittest.test.testmock']
- del sys.modules['unittest.test']
+ del sys.modules['test.test_unittest.testmock.support']
+ del sys.modules['test.test_unittest.testmock']
+ del sys.modules['test.test_unittest']
del sys.modules['unittest']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This seems to reflect better the original meaning of the code before c735d54, and it should fix the consistent warning on most refleak buildbots.